Fix Custom Headers are not saved for OpenAI Compatible providers (#383) #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that when users added or modified custom headers, the changes were only stored in the local component state but never propagated to the main configuration object that gets saved. The fix adds a `useEffect` hook that updates the main configuration whenever the custom headers change, ensuring they're properly saved when the user clicks the "Save" button. Now users can successfully add custom headers to their OpenAI Compatible provider configurations. Test plan: - Added a header confirmed it saved - Added header, discarded changes, confirmed header is gone
kevinvandijk
approved these changes
May 13, 2025
Contributor
Author
|
Roo fixed this, so closing our version: RooCodeInc/Roo-Code#3415. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that when users added or modified custom headers, the changes were only stored in the local component state but never propagated to the main configuration object that gets saved.
The fix adds a
useEffecthook that updates the main configuration whenever the custom headers change, ensuring they're properly saved when the user clicks the "Save" button.Now users can successfully add custom headers to their OpenAI Compatible provider configurations.
Test plan:
Fixes: #383